Skip to content

toolchain update#21

Merged
dgreid merged 4 commits intorivosinc:mainfrom
dgreid:topic/toolchain_update
Apr 8, 2025
Merged

toolchain update#21
dgreid merged 4 commits intorivosinc:mainfrom
dgreid:topic/toolchain_update

Conversation

@dgreid
Copy link
Contributor

@dgreid dgreid commented Apr 5, 2025

To prepare for the salus toolchain update, get sbi-rs building with a recent toolchain and get its dependencies up to date.

@dgreid dgreid requested review from atishp04 and Copilot April 5, 2025 01:21
@dgreid dgreid self-assigned this Apr 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • BUILD: Language not supported
  • bazel-locks/sbi-cargo-bazel-lock.json: Language not supported
  • deps.bzl: Language not supported

dgreid added 3 commits April 8, 2025 09:58
`this function depends on never type fallback being `()``

Will be a hard error with newer toolchains so resolve it now.

Signed-off-by: Dylan Reid <dgreid@rivosinc.com>
Fixes a clippy lint that was introduced recently.

Signed-off-by: Dylan Reid <dgreid@rivosinc.com>
Clippy has gotten more strict with doc comments.

Signed-off-by: Dylan Reid <dgreid@rivosinc.com>
@dgreid dgreid force-pushed the topic/toolchain_update branch from 3dd891a to 8882db3 Compare April 8, 2025 17:05
Remove unused enum_dispatch which was pulling in a stale proc_macro that
is not used by this crate.

Signed-off-by: Dylan Reid <dgreid@rivosinc.com>
@dgreid dgreid force-pushed the topic/toolchain_update branch from 8882db3 to e911b13 Compare April 8, 2025 17:22
@dgreid dgreid merged commit f0d05a5 into rivosinc:main Apr 8, 2025
2 checks passed
@dgreid dgreid deleted the topic/toolchain_update branch April 8, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants